Re: [media] spca500: Use common error handling code in spca500_synch310()

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [media] spca500: Use common error handling code in spca500_synch310()
Date	2017-09-22 19:50 +0200
Message-ID	<usAfn-xX-9@gated-at.bofh.it> (permalink)
References	<uszCG-kW-3@gated-at.bofh.it> <uszCG-kW-5@gated-at.bofh.it> <usAfn-xX-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Fri, 22 Sep 2017, SF Markus Elfring wrote:

> >>  	return 0;
> >> -error:
> >> +
> >> +report_failure:
> >> +	PERR("Set packet size: set interface error");
> >>  	return -EBUSY;
> >>  }
> >
> > Why change the label name?
>
> I find the suggested variant a bi better.
>
>
> > They are both equally uninformative.
>
> Which identifier would you find appropriate there?

error was fine.

julia

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:10 +0200
  Re: [PATCH] [media] spca500: Use common error handling code in  spca500_synch310() Julia Lawall <julia.lawall@lip6.fr> - 2017-09-22 19:10 +0200
    Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:50 +0200
      Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 19:50 +0200
        Re: [media] spca500: Use common error handling code in  spca500_synch310() Daniele Nicolodi <daniele@grinta.net> - 2017-09-22 20:40 +0200
          Re: [media] spca500: Use common error handling code in  spca500_synch310() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-22 22:50 +0200
        Re: [media] spca500: Use common error handling code in  spca500_synch310() Joe Perches <joe@perches.com> - 2017-09-22 20:40 +0200
      Re: [media] spca500: Use common error handling code in  spca500_synch310() Julia Lawall <julia.lawall@lip6.fr> - 2017-09-22 19:50 +0200

csiph-web