Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736529

Re: [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing

Show all headers | View raw

Hi Douglas,

On Wednesday 20 September 2017 01:26 AM, Douglas Anderson wrote:
> When connecting to certain DP monitors it was observed that only one
> of the two orientations of the type C to DP cable would work.
> Debugging showed that the problem was that we needed to set the type C
> "flip" state earlier.  Once we did this, problems went away.
> 
> While trying to dig into this problem and some others, I found that
> the proper documentation for the Type C PHY was available to me.  This
> allowed me to cleanup the magic numbers in the funtion that I was
> touching and also fix a few minor issues that (luckily) haven't caused
> any problems yet.
> 
> I also found that aux channel communications were flaky on some
> adapters until I adjusted the voltage swing.

From the commit log, looks like only the 1st and 4th patch are fixes. Only
those can go in -rc cycle. But I can't apply the 4th patch without the 2nd and
3rd patch.

Can you resend the series such that 2nd and 3rd patch apply on top of 1st and
4th patch?

Thanks
Kishon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing Douglas Anderson <dianders@chromium.org> - 2017-09-19 22:00 +0200
  [PATCH v2 1/4] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson <dianders@chromium.org> - 2017-09-19 22:00 +0200
  [PATCH v2 2/4] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson <dianders@chromium.org> - 2017-09-19 22:00 +0200
  [PATCH v2 3/4] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson <dianders@chromium.org> - 2017-09-19 22:00 +0200
  [PATCH v2 4/4] phy: rockchip-typec: Don't set the aux voltage swing to 400 mV Douglas Anderson <dianders@chromium.org> - 2017-09-19 22:00 +0200
  Re: [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some  cleanups; fix swing Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-21 12:40 +0200
    Re: [PATCH v2 0/4] phy: rockchip-typec: Set "flip" properly; some  cleanups; fix swing Doug Anderson <dianders@chromium.org> - 2017-09-22 18:50 +0200

csiph-web