Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in
Date	2017-09-21 12:30 +0200
Message-ID	<us6U2-83f-19@gated-at.bofh.it> (permalink)
References	<us3CN-5Ky-7@gated-at.bofh.it> <us3Wa-69n-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-09-21 at 10:15 +0300, Dan Carpenter wrote:
> On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> > --- a/drivers/staging/rtl8188eu/hal/phy.c
> > +++ b/drivers/staging/rtl8188eu/hal/phy.c
> > @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
> >  	u32 oldval_0, x, tx0_a, reg;
> >  	s32 y, tx0_c;
> >  
> > -	if (final_candidate == 0xFF) {
> > +	if (final_candidate == 0xFF)
> >  		return;
> > -	} else if (iqkok) {
> > +	else if (iqkok) {
> 
> No.  These ones stay.  Your change would introduce a new checkpatch.pl
> warning if you ran it against the patched file.  The rule here is that
> if one side of the if else has curly braces then both sides get them.

And the else could be removed

	if (final_candidate == 0xff)
		return;

	if (iqkok) {
		[etc...]

and the code should probably be

	if (final_candidate == 0xff)
		return;

	if (!iqkok)
		return;

	[unindented etc...]

or combine the first 2 tests

	if (final_candidate == 0xff || !iqkok)
		return;

	[unindented etc...]

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:rtl8188eu Remove unnecessary {} braces in Janani Sankara Babu <jananis37@gmail.com> - 2017-09-21 09:00 +0200
  Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-21 09:20 +0200
    Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in Joe Perches <joe@perches.com> - 2017-09-21 12:30 +0200

csiph-web