Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736416

Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in

Show all headers | View raw

On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
>  	u32 oldval_0, x, tx0_a, reg;
>  	s32 y, tx0_c;
>  
> -	if (final_candidate == 0xFF) {
> +	if (final_candidate == 0xFF)
>  		return;
> -	} else if (iqkok) {
> +	else if (iqkok) {

No.  These ones stay.  Your change would introduce a new checkpatch.pl
warning if you ran it against the patched file.  The rule here is that
if one side of the if else has curly braces then both sides get them.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging:rtl8188eu Remove unnecessary {} braces in Janani Sankara Babu <jananis37@gmail.com> - 2017-09-21 09:00 +0200
  Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-21 09:20 +0200
    Re: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in Joe Perches <joe@perches.com> - 2017-09-21 12:30 +0200

csiph-web