Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1735291

Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Kees Cook <keescook@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS
Date Wed, 20 Sep 2017 00:10:01 +0200
Message-ID <urySl-2Ga-7@gated-at.bofh.it> (permalink)
References <uoyOS-5b8-11@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=; b=nD96YmcbHLT/ZYY7SGSqV8duKc/LzG8dmcrZhLKyxKZBj9I30FLND1c2n1c+X17f1o rJ3ZY2Tapw5prN72w+2RgrkfF0vNwhg4om1+fBXv2ccZPDKlRjpPMrGnxCTpUuM7kqaz 0V2w9EuR8TF5gMCvFL944XcK46lrmtDPTpiaOLVLj+InNv7TshqqBjYbUprQwteg7pic NJO0MGFuh5ndoxnJwicpFC/xjw/iEyIL6Xqtr+BvrYEIp3yOiD42Mz7uQkoRihWKi+vP Gr6rSRMp5zT0HZIoHI521i29q25EcDt4mtN6UfhfS4bqP+w2Z8SEBF3PVJ3c7LXVmVZl o1bA==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=; b=f3wD8Tf/5yBf6MXnghZhoGdHU1MQ5g+hJ2LL97XxeoPJrAnmIF46Iq7rdIgaG9YorR rLGYeV5fY8xql/lVLRdmtkynT5pAbuRj120pN2odgUJ4fcY60EgmarV1hNU7wxHXnM6D +5NlhgAUZanrmGztBEAHweJ8OKF6Tt57Yeob0=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=; b=mMLNkRK+qE287CdBWUKA0eU4OJG11nwxdcBml3CUBm/wf4kSH0+oRt7FIdc7kSrPxF L3drBck57YrM4tS45MIRcPcvWvBWA3UgBgF/3vNumJJTw/ykL4NW7/PaKFczStdvq0+5 Y20x6YR+w3ZuuIWaeTa3e6MI0zLGGfuJrYOui9hjS5k4d8hGXulb2d39oRdZ1Xm0rKYY QCZFHFOzXlKXWH9OGya1cWWJERSJFhsp6uDv15XYKPelLz7epL3MhEun9iganADsFulW 6e2j33Ij2HF5dhFf+UX378am4VH4DEqgEeGB2NVxbMtcrn8QDFAFtFWSt7KQg3pDls/N i+iw==
X-Gm-Message-State AHPjjUg3DezD13/LaxrekTZShaLcLQ8vUEHAS8jsL1oymOuJYBV2QFI6 g7VD2zVsOxQYAN5HexoOxp78JAQKsMcBR8UgFFBVmKqq
X-Google-SMTP-Source AOwi7QDog6EiyJGC0F42/vcVMPnKQ+33l0tKYJs7Cqa3Z0KJ0YY5FnSq3XdSRBwZAEO5A++IgVkMWswI5Ceb+OmQ/v8=
X-Received by 10.107.9.90 with SMTP id j87mr375582ioi.111.1505858543486; Tue, 19 Sep 2017 15:02:23 -0700 (PDT)
MIME-Version 1.0
X-Google-Sender-Auth aS0p35sy7mSALVBBMxq5c01uyFM
Content-Type text/plain; charset="UTF-8"
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 30
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, kevin.brodsky@arm.com, Ingo Molnar <mingo@kernel.org>, Christian Borntraeger <borntraeger@de.ibm.com>, James Morse <james.morse@arm.com>, Peter Zijlstra <peterz@infradead.org>, Dave Martin <Dave.Martin@arm.com>, credmonster@gmail.com, zijun_hu <zijun_hu@htc.com>, Mark Rutland <mark.rutland@arm.com>, Jisheng Zhang <jszhang@marvell.com>, Laura Abbott <labbott@redhat.com>, John Stultz <john.stultz@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, AKASHI Takahiro <takahiro.akashi@linaro.org>, Michal Marek <mmarek@suse.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>
X-Original-Date Tue, 19 Sep 2017 15:02:22 -0700
X-Original-Message-ID <CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>
X-Original-References <20170911152635.95367-1-salyzyn@android.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1735291

Show key headers only | View raw


On Mon, Sep 11, 2017 at 8:26 AM, Mark Salyzyn <salyzyn@android.com> wrote:
> Make it possible to disable the kuser helpers by adding a KUSER_HELPERS
> config option (enabled by default). When disabled, all kuser
> helpers-related code is removed from the kernel and no mapping is done
> at the fixed high address (0xffff0000); any attempt to use a kuser
> helper from a 32-bit process will result in a segfault.
>
> Signed-off-by: Mark Salyzyn <salyzyn@android.com>
>
> v2:
> - vectors_page and compat_vdso_spec as array of 2
> - free sigpage if vectors allocation failed
> - adjust makefile so one line for each of the assembler source modules
> - split off assembler changes to a new previous patch in series to reduce churn
> - modify slightly the feature documentation to reduce its reach
> - modify slightly the feature documentation to rationalize the yes default.
> - There are more ifdefs as a result of the rebase.
>
> v3:
> - rebase (minor conflicts)

This looks great to me. I'd love to see kuser helpers gone. :)

Catalin, Will, does this need anything else?

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS Mark Salyzyn <salyzyn@android.com> - 2017-09-11 17:30 +0200
  Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS Kees Cook <keescook@chromium.org> - 2017-09-20 00:10 +0200
    Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS Will Deacon <will.deacon@arm.com> - 2017-09-20 11:20 +0200

csiph-web