Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops
Date	2017-09-20 00:00 +0200
Message-ID	<uryIG-2nT-13@gated-at.bofh.it> (permalink)
References	(2 earlier) <uregV-5fg-1@gated-at.bofh.it> <urq8q-5xV-19@gated-at.bofh.it> <urrQS-6Dj-17@gated-at.bofh.it> <urt6i-7kk-27@gated-at.bofh.it> <urxCW-1Jf-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 19 Sep 2017 13:41:35 -0700
Christoph Hellwig <hch@infradead.org> wrote:

> Call it blk_trace mutex and move it right next to the blk_trace
> structure:
> 
> ifdef CONFIG_BLK_DEV_IO_TRACE
>         struct blk_trace        *blk_trace;
> 	struct mutex		blk_trace_mutex;
> #endif
> 
> which makes it completely obvious to any read what you are protecting
> with it.

As a 1000ft away bystander, this appears to be the most logical
solution.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long <longman@redhat.com> - 2017-09-18 21:00 +0200
  Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 02:10 +0200
    Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-09-19 14:50 +0200
      Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 16:40 +0200
        Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-09-19 18:00 +0200
          Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 22:50 +0200
            Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete  & sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-09-20 00:00 +0200

csiph-web