Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734552

Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops
Date 2017-09-19 02:10 +0200
Message-ID <uregV-5fg-1@gated-at.bofh.it> (permalink)
References <ur9qV-1Et-7@gated-at.bofh.it> <ur9qV-1Et-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Taking a look at this it seems like using a lock in struct block_device
isn't the right thing to do anyway - all the action is on fields in
struct blk_trace, so having a lock inside that would make a lot more
sense.

It would also help to document what exactly we're actually protecting.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v6 1/2] blktrace: Fix potentail deadlock between delete & sysfs ops Waiman Long <longman@redhat.com> - 2017-09-18 21:00 +0200
  Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 02:10 +0200
    Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-09-19 14:50 +0200
      Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 16:40 +0200
        Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Waiman Long <longman@redhat.com> - 2017-09-19 18:00 +0200
          Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete &  sysfs ops Christoph Hellwig <hch@infradead.org> - 2017-09-19 22:50 +0200
            Re: [PATCH v6 1/2] blktrace: Fix potentail deadlock between delete  & sysfs ops Steven Rostedt <rostedt@goodmis.org> - 2017-09-20 00:00 +0200

csiph-web