Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734632
| Path | csiph.com!goblin1!goblin.stu.neva.ru!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Tejun Heo <tj@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ata: pata_artop: remove redundant initialization of pio |
| Date | Tue, 19 Sep 2017 05:30:02 +0200 |
| Message-ID | <urhou-7ap-3@gated-at.bofh.it> (permalink) |
| References | <upHwK-hq-13@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Wp3MaLgoj/4TcKK2kIt0R6YvX1TzH2SuOLToS8GjLGo=; b=MRCKiUMc2F/vgwjBTZKngaBXXOm4RApCGl/lXKhquXap7Cp+XevkcnOvY1kZ/u45At XoqHbos/VJMzb8ylZJsYHEYT4bp+tz5i3xUaKf5Cg/FVPiPqW434wLarF6eBzLaxiFON H09AHfriW1HaEW2gCVH40YNO7WecqCHFptMFwvLm0/V9MeqXCKg8IUDt3I1ODaEmbFVZ 8pCnk2DLyLuxKS1Kt5WQRPZtJURga8i8LWbmLBmvPupOdWsKgr4YkM9yemOBfdRKuOZo LdEWWSzxHcLxO6+FCOxzvft8WsgRpXBvXsLbnktRJgcNE91iMVUhs6mhKMuFMUCv9Evc qT+g== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Wp3MaLgoj/4TcKK2kIt0R6YvX1TzH2SuOLToS8GjLGo=; b=ooX/0XoSE+CP1K8In/MEyEeGbclyjlrZUgW7F8SovMaUojERzGERIJhJEDTBaPuBul 2+8i6AuOAAQpyWZDbHr9CvDwjOr7tY/vYIJcZv0c9cxMC7QOaHRj+3Y1UMUqZdJ/jby5 KPE/O8UWOdy5UVIXsCIFvfzB6Zs+WBWBBal8l0t5zvefPSOiUvlHho10B9mfoJFxWapT Bu/W8wBrw0GCLMm4G8fVbu2YnWTnruyTDd8fNxe/KsxUoY5sBpOl+fq3F5wPSHBBnxr7 MQSRuXqg+/wTwlwZYV4WPLy138p6HcSJnKuuKSc6qBtk/AMvc0V2RTRSc9BYORELjf5O PXqQ== |
| X-Gm-Message-State | AHPjjUh44yNVXnl55dtto97urRdU4Alip0XC7DQ+zJv/AMoXl7BMCRVO QZDDC4jP/fa/lBPr9bCgyoo= |
| X-Google-SMTP-Source | AOwi7QC+za4I645hWj/6OJPpPhjoreVBq/Gtl9Rw7ijhLq/Op3I64KaRnE1t7ldnvF6Wq259xFZaOw== |
| X-Received | by 10.200.43.123 with SMTP id 56mr4581qtv.15.1505791495377; Mon, 18 Sep 2017 20:24:55 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 19 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 18 Sep 2017 20:24:52 -0700 |
| X-Original-Message-ID | <20170919032452.GN378890@devbig577.frc2.facebook.com> |
| X-Original-References | <20170914185418.13790-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1734632 |
Show key headers only | View raw
On Thu, Sep 14, 2017 at 07:54:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pio is initialized and the data is never read, instead it is almost
> immediately being updated to a new value. Fix this by removing the
> initialization.
>
> Detected by scan-build:
> "warning: Value stored to 'pio' during its initialization is never read"
>
> Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to libata/for-4.15.
Thanks.
--
tejun
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] ata: pata_artop: remove redundant initialization of pio Colin King <colin.king@canonical.com> - 2017-09-14 21:00 +0200 Re: [PATCH] ata: pata_artop: remove redundant initialization of pio Tejun Heo <tj@kernel.org> - 2017-09-19 05:30 +0200
csiph-web