Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1734632

Re: [PATCH] ata: pata_artop: remove redundant initialization of pio

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ata: pata_artop: remove redundant initialization of pio
Date 2017-09-19 05:30 +0200
Message-ID <urhou-7ap-3@gated-at.bofh.it> (permalink)
References <upHwK-hq-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Sep 14, 2017 at 07:54:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> pio is initialized and the data is never read, instead it is almost
> immediately being updated to a new value. Fix this by removing the
> initialization.
> 
> Detected by scan-build:
> "warning: Value stored to 'pio' during its initialization is never read"
> 
> Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to libata/for-4.15.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] ata: pata_artop: remove redundant initialization of pio Colin King <colin.king@canonical.com> - 2017-09-14 21:00 +0200
  Re: [PATCH] ata: pata_artop: remove redundant initialization of pio Tejun Heo <tj@kernel.org> - 2017-09-19 05:30 +0200

csiph-web