Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734514

Re: [PATCH 2/3] selftests: actually run the various net selftests

Show all headers | View raw

On 09/18/2017 11:32 AM, josef@toxicpanda.com wrote:
> From: Josef Bacik <jbacik@fb.com>
> 
> These self tests are just self contained binaries, they are not run by
> any of the scripts in the directory.  This means they need to be marked
> with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES.
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> ---
>  tools/testing/selftests/net/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 3df542c84610..45a4e77a47c4 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -6,8 +6,8 @@ CFLAGS += -I../../../../usr/include/
>  TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh rtnetlink.sh
>  TEST_GEN_FILES =  socket
>  TEST_GEN_FILES += psock_fanout psock_tpacket
> -TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa
> -TEST_GEN_FILES += reuseport_dualstack msg_zerocopy reuseaddr_conflict
> +TEST_GEN_PROGS += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa
> +TEST_GEN_PROGS += reuseport_dualstack msg_zerocopy reuseaddr_conflict

Hmm. I see msg_zerocopy.sh for running msg_zerocopy. msg_zerocopy should
still stay in TEST_GEN_FILES and msg_zerocopy.sh needs to be added to
TEST_PROGS so it runs.

thanks,
-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] selftest: add a reuseaddr test josef@toxicpanda.com - 2017-09-18 19:40 +0200
  [PATCH 3/3] selftests: silence test output by default josef@toxicpanda.com - 2017-09-18 19:40 +0200
    Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuah@kernel.org> - 2017-09-18 19:50 +0200
      Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 20:00 +0200
        Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 20:20 +0200
          Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 20:30 +0200
            Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 21:50 +0200
              Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 22:20 +0200
                Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 23:40 +0200
  [PATCH 2/3] selftests: actually run the various net selftests josef@toxicpanda.com - 2017-09-18 19:40 +0200
    Re: [PATCH 2/3] selftests: actually run the various net selftests Shuah Khan <shuah@kernel.org> - 2017-09-19 00:20 +0200
      Re: [PATCH 2/3] selftests: actually run the various net selftests Josef Bacik <josef@toxicpanda.com> - 2017-09-19 15:40 +0200
        Re: [PATCH 2/3] selftests: actually run the various net selftests Willem de Bruijn <willemdebruijn.kernel@gmail.com> - 2017-09-19 20:20 +0200
          Re: [PATCH 2/3] selftests: actually run the various net selftests Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-19 22:10 +0200

csiph-web