Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734336

Re: [PATCH 3/3] selftests: silence test output by default

Show all headers | View raw

On 09/18/2017 11:37 AM, josef@toxicpanda.com wrote:
> From: Josef Bacik <jbacik@fb.com>
> 
> Some of the networking tests are very noisy and make it impossible to
> see if we actually passed the tests as they run.  Default to suppressing
> the output from any tests run in order to make it easier to track what
> failed.
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>
> --

This change suppresses pass/fail wrapper output for all tests, not just the
networking tests.

Could you please send me before and after results for what you are trying
to fix.

>  tools/testing/selftests/lib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 693616651da5..223234cd98e9 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -24,7 +24,7 @@ define RUN_TESTS
>  			echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\
>  			echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \
>  		else					\
> -			cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests:  $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\
> +			cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST > /dev/null 2>&1 && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests:  $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\
>  		fi;					\
>  	done;
>  endef
> @@ -55,7 +55,7 @@ endif
>  define EMIT_TESTS
>  	@for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \
>  		BASENAME_TEST=`basename $$TEST`;	\
> -		echo "(./$$BASENAME_TEST && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \
> +		echo "(./$$BASENAME_TEST > /dev/null 2>&1 && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \
>  	done;
>  endef
>  
> 

thanks,
-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] selftest: add a reuseaddr test josef@toxicpanda.com - 2017-09-18 19:40 +0200
  [PATCH 3/3] selftests: silence test output by default josef@toxicpanda.com - 2017-09-18 19:40 +0200
    Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuah@kernel.org> - 2017-09-18 19:50 +0200
      Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 20:00 +0200
        Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 20:20 +0200
          Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 20:30 +0200
            Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 21:50 +0200
              Re: [PATCH 3/3] selftests: silence test output by default Josef Bacik <josef@toxicpanda.com> - 2017-09-18 22:20 +0200
                Re: [PATCH 3/3] selftests: silence test output by default Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-18 23:40 +0200
  [PATCH 2/3] selftests: actually run the various net selftests josef@toxicpanda.com - 2017-09-18 19:40 +0200
    Re: [PATCH 2/3] selftests: actually run the various net selftests Shuah Khan <shuah@kernel.org> - 2017-09-19 00:20 +0200
      Re: [PATCH 2/3] selftests: actually run the various net selftests Josef Bacik <josef@toxicpanda.com> - 2017-09-19 15:40 +0200
        Re: [PATCH 2/3] selftests: actually run the various net selftests Willem de Bruijn <willemdebruijn.kernel@gmail.com> - 2017-09-19 20:20 +0200
          Re: [PATCH 2/3] selftests: actually run the various net selftests Shuah Khan <shuahkh@osg.samsung.com> - 2017-09-19 22:10 +0200

csiph-web