Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob

From	严海双 <yanhaishuang@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob
Date	2017-09-21 04:00 +0200
Message-ID	<urYWt-2C8-3@gated-at.bofh.it> (permalink)
References	<urnax-2OZ-3@gated-at.bofh.it> <urUJd-8w7-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> On 2017年9月21日, at 上午5:22, David Miller <davem@davemloft.net> wrote:
> 
> From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
> Date: Tue, 19 Sep 2017 17:38:14 +0800
> 
>> -		if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) &&
>> -		    (sysctl_tcp_fastopen & TFO_SERVER_ENABLE) &&
>> +		tcp_fastopen =  sock_net(sk)->ipv4.sysctl_tcp_fastopen;
>                              ^^
> 
> Please change that to one space.
> 
> And also please provide an appropriate "[PATCH vX 0/3] " header
> posting when you respin this series.

Sorry, it’s my mistake, thanks David.
> 
>> @@ -282,18 +280,19 @@ struct sock *tcp_try_fastopen(struct sock *sk, struct sk_buff *skb,
>> 	struct tcp_fastopen_cookie valid_foc = { .len = -1 };
>> 	bool syn_data = TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq + 1;
>> 	struct sock *child;
>> +	int tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen;
> 
> Please order local variables from longest to shortest line (aka. reverse
> christmas tree format).
> 

Okay, I’ll take care of such coding style in next commit, thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-19 11:40 +0200
  [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-19 11:40 +0200
    Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob David Miller <davem@davemloft.net> - 2017-09-20 23:30 +0200
  Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob David Miller <davem@davemloft.net> - 2017-09-20 23:30 +0200
    Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-21 04:00 +0200

csiph-web