Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1736171

Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob
Date 2017-09-20 23:30 +0200
Message-ID <urUJd-8w7-39@gated-at.bofh.it> (permalink)
References <urnax-2OZ-3@gated-at.bofh.it> <urnax-2OZ-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Tue, 19 Sep 2017 17:38:15 +0800

> @@ -128,6 +130,8 @@ struct netns_ipv4 {
>  	struct inet_timewait_death_row tcp_death_row;
>  	int sysctl_max_syn_backlog;
>  	int sysctl_tcp_fastopen;
> +	struct tcp_fastopen_context __rcu *tcp_fastopen_ctx;
> +	spinlock_t tcp_fastopen_ctx_lock;
>  
>  #ifdef CONFIG_NET_L3_MASTER_DEV
>  	int sysctl_udp_l3mdev_accept;

Where are you releasing this context during netns teardown?
I think this is a leak.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-19 11:40 +0200
  [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-19 11:40 +0200
    Re: [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob David Miller <davem@davemloft.net> - 2017-09-20 23:30 +0200
  Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob David Miller <davem@davemloft.net> - 2017-09-20 23:30 +0200
    Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-21 04:00 +0200

csiph-web