Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736277

Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning
Date 2017-09-21 02:30 +0200
Message-ID <urXxn-1QS-5@gated-at.bofh.it> (permalink)
References <urQ2S-5so-15@gated-at.bofh.it> <urQcy-5vV-29@gated-at.bofh.it> <urR8B-67N-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On (09/20/17 10:38), Joe Perches wrote:
> On Thu, 2017-09-21 at 01:29 +0900, Sergey Senozhatsky wrote:
> > We deprecated '%pF/%pf' printk specifiers, since '%pS/%ps' is now smart
> > enough to handle function pointer dereference on platforms where such
> > dereference is required.
> > 
> > checkpatch warning example:
> > 
> > WARNING: Use '%pS/%ps' instead. This pointer extension was deprecated: '%pF'
> 
> If this series is accepted,  I think this message
> is unclear and would prefer something like:

sure, can tweak the patch.

[..]
>  			if ($bad_extension ne "") {
>  				my $stat_real = raw_line($linenr, 0);
> +				my $ext_type = "Invalid";
> +				my $use = "";
>  				for (my $count = $linenr + 1; $count <= $lc; $count++) {
>  					$stat_real = $stat_real . "\n" . raw_line($count, 0);
>  				}
> +				if ($bad_extension =~ /p[Ff]/i) {
						I think /i is not necessary here

> +					$ext_type = "Deprecated";
> +					$use = " - use %pS instead";
> +					$use =~ s/pS/ps/ if ($bad_extension =~ /pf/);
							ok, handy :)

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:30 +0200
  [RFC][PATCH v2 2/7] sections: split dereference_function_descriptor() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:30 +0200
  [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
    Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
  [RFC][PATCH v2 1/7] switch dereference_function_descriptor() to `unsigned long' Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
  [RFC][PATCH v2 5/7] parisc64: Add .opd based function descriptor dereference Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
  [RFC][PATCH v2 4/7] powerpc64: Add .opd based function descriptor dereference Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
  [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
    Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Joe Perches <joe@perches.com> - 2017-09-20 19:40 +0200
      Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Helge Deller <deller@gmx.de> - 2017-09-20 20:00 +0200
        Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Joe Perches <joe@perches.com> - 2017-09-20 20:30 +0200
          Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-21 09:50 +0200
      Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-21 02:30 +0200
        Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning Joe Perches <joe@perches.com> - 2017-09-21 04:30 +0200
  [RFC][PATCH v2 6/7] symbol lookup: use new kernel and module dereference functions Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2017-09-20 18:40 +0200
    Re: [RFC][PATCH v2 6/7] symbol lookup: use new kernel and module  dereference functions Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-21 11:40 +0200
  Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Helge Deller <deller@gmx.de> - 2017-09-20 22:20 +0200
    Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-21 02:40 +0200
  Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Santosh Sivaraj <santosh@fossix.org> - 2017-09-22 07:40 +0200
    Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-22 10:10 +0200
      RE: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers "Luck, Tony" <tony.luck@intel.com> - 2017-09-22 18:50 +0200
        Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-25 09:10 +0200
          RE: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers "Luck, Tony" <tony.luck@intel.com> - 2017-09-25 18:40 +0200
            Re: [RFC][PATCH v2 0/7] printk/ia64/ppc64/parisc64: let's deprecate  %pF/%pf printk specifiers Helge Deller <deller@gmx.de> - 2017-09-25 19:10 +0200

csiph-web