Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1735850

[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Jens Axboe <axboe@kernel.dk>
Newsgroups linux.kernel
Subject [PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup
Date Wed, 20 Sep 2017 17:40:02 +0200
Message-ID <urPgu-4TY-23@gated-at.bofh.it> (permalink)
References <urPgt-4TY-13@gated-at.bofh.it>
X-Original-To linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r0qrz0wAhbZDNRPGAH5YuWum5RJGClyZzdVk9YOcAQY=; b=bxjTxR+wq58UiUIZ+H/vKNbZgqQx6RpAp0m/ND7dp+vcfx5ONBqVF7dtZx+TUfAHEF dV5VZ+hvNmxD3V8IS+hisp4WiuASUu2lFn8Sl7b7sUn4pDZVQtBf1u2SoG6ZljVX3tY1 N5Ydje8Ht0Qecdf/B+EvypkDZ/bwHGkZ2qheZ4WlinjuD9GaN52ngI8w7q3x+TQInn3Q XFUBOSP/5uJEtqz7bGVJkglUrdUCUJZCH2z9Tcrnamc+c/+LR4AyrwP+z3D9+Z0gM0ip TrYLdGqA2xAWIDCzcNEsK5GggcmhETLNMcC0v2U3kiuNLVjucQHR1x3Z8cp/pnmUmqom w93w==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r0qrz0wAhbZDNRPGAH5YuWum5RJGClyZzdVk9YOcAQY=; b=gBtbDzTZWI8XApa7tWLoDLo7MpZyM63D6n4zNegwwzVQ+sKpATWViWg1M3ZxTOh1kZ sqCuSU+ehh7HpUfDWxhRYxJkvXG+81esFZmP/m2UAWeGfC74R3vhZBxHhlAoKp/1eUSo 754DBW7ySu6V148fLVwf+9hKSgG944bad7NrC4x2RwCFQTPjH16ARRMfzhqPGNgUXFm1 sdzJoHPlRu2h8G/lhAFVZQ2UUlqcJC4R85S210h6MtE8thoBzgaMT97yB2GNhrdNvJDH /ktHnkG2K00W0pAJdsmc/3xRs3aiDXdWSw2gDQ7hQUZyJtJbwAtPqCSQ/+FMBCkkK73V tNkA==
X-Gm-Message-State AHPjjUiPXCuw7an1U6h3rRJzEvBU+UJHHVsPEM1koJgiTf1HYy8UhOo7 k2zOMgKIrBjRU8YQEYX6Bsbs1wsNmF4=
X-Google-SMTP-Source AOwi7QDw2uC3I+Hy6QgZH5joI04qcrWUgVwUAOkPN9acKa0/mdp+GrlQ7NQ/rMvSja24H2/ZPoM5QQ==
X-Received by 10.107.201.80 with SMTP id z77mr6626637iof.257.1505921599704; Wed, 20 Sep 2017 08:33:19 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc hannes@cmpxchg.org, clm@fb.com, jack@suse.cz, Jens Axboe <axboe@kernel.dk>
X-Original-Date Wed, 20 Sep 2017 09:32:56 -0600
X-Original-Message-ID <1505921582-26709-2-git-send-email-axboe@kernel.dk>
X-Original-References <1505921582-26709-1-git-send-email-axboe@kernel.dk>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1735850

Show key headers only | View raw


This whole function is... interesting. Change the wakeup call
to the flusher threads to pass in nr_pages == 0, instead of
some random number of pages. This matches more closely what
similar cases do for memory shortage/reclaim.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Tested-by: Chris Mason <clm@fb.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 fs/buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 170df856bdb9..9471a445e370 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -260,7 +260,7 @@ static void free_more_memory(void)
 	struct zoneref *z;
 	int nid;
 
-	wakeup_flusher_threads(1024, WB_REASON_FREE_MORE_MEM);
+	wakeup_flusher_threads(0, WB_REASON_FREE_MORE_MEM);
 	yield();
 
 	for_each_online_node(nid) {
-- 
2.7.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:40 +0200
  Re: [PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:00 +0200

csiph-web