[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup
Date	2017-09-20 17:40 +0200
Message-ID	<urPgu-4TY-23@gated-at.bofh.it> (permalink)
References	<urPgt-4TY-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This whole function is... interesting. Change the wakeup call
to the flusher threads to pass in nr_pages == 0, instead of
some random number of pages. This matches more closely what
similar cases do for memory shortage/reclaim.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Tested-by: Chris Mason <clm@fb.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 fs/buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/buffer.c b/fs/buffer.c
index 170df856bdb9..9471a445e370 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -260,7 +260,7 @@ static void free_more_memory(void)
 	struct zoneref *z;
 	int nid;
 
-	wakeup_flusher_threads(1024, WB_REASON_FREE_MORE_MEM);
+	wakeup_flusher_threads(0, WB_REASON_FREE_MORE_MEM);
 	yield();
 
 	for_each_online_node(nid) {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:40 +0200
  Re: [PATCH 1/7] buffer: cleanup free_more_memory() flusher wakeup Christoph Hellwig <hch@infradead.org> - 2017-09-21 17:00 +0200

csiph-web