Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735842

Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode

Show all headers | View raw

On 09/20/2017 08:35 AM, Jan Kara wrote:
> On Tue 19-09-17 13:53:04, Jens Axboe wrote:
>> Laptop mode really wants to writeback the number of dirty
>> pages and inodes. Instead of calculating this in the caller,
>> just pass in 0 and let wakeup_flusher_threads() handle it.
>>
>> Use the new wakeup_flusher_threads_bdi() instead of rolling
>> our own.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ...
>> -	rcu_read_lock();
>> -	list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node)
>> -		if (wb_has_dirty_io(wb))
>> -			wb_start_writeback(wb, nr_pages, true,
>> -					   WB_REASON_LAPTOP_TIMER);
>> -	rcu_read_unlock();
>> +	wakeup_flusher_threads_bdi(q->backing_dev_info, 0,
>> +					WB_REASON_LAPTOP_TIMER);
>>  }
> 
> So this slightly changes the semantics since previously we were doing
> range_cyclic writeback and now we don't. I don't think this matters in
> practice but please mention that in the changelog. With that you can add:

Thanks, I added a note about that in the commit message.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
  [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Jan Kara <jack@suse.cz> - 2017-09-20 16:40 +0200
      Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in  laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:30 +0200
  [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jan Kara <jack@suse.cz> - 2017-09-20 16:30 +0200
  [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jan Kara <jack@suse.cz> - 2017-09-20 16:50 +0200
      Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:10 +0200
        Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jan Kara <jack@suse.cz> - 2017-09-20 17:40 +0200
          Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:50 +0200
  [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jan Kara <jack@suse.cz> - 2017-09-20 16:20 +0200
      Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:20 +0200
  [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:20 +0200
      Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:40 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 04:00 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Amir Goldstein <amir73il@gmail.com> - 2017-09-20 05:20 +0200
      Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 06:20 +0200
        Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Amir Goldstein <amir73il@gmail.com> - 2017-09-20 08:10 +0200
          Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 14:40 +0200
        Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jan Kara <jack@suse.cz> - 2017-09-20 16:50 +0200
  Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup John Stoffel <john@quad.stoffel.home> - 2017-09-20 21:40 +0200
    Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 21:40 +0200
      Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Johannes Weiner <hannes@cmpxchg.org> - 2017-09-21 01:20 +0200

csiph-web