Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735817

Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location

Show all headers | View raw

On 09/20/2017 08:41 AM, Jan Kara wrote:
> On Tue 19-09-17 13:53:06, Jens Axboe wrote:
>> Now that we have no external callers of wb_start_writeback(),
>> we can move the nr_pages == 0 logic into that function.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> 
> ...
> 
>> +static unsigned long get_nr_dirty_pages(void)
>> +{
>> +	return global_node_page_state(NR_FILE_DIRTY) +
>> +		global_node_page_state(NR_UNSTABLE_NFS) +
>> +		get_nr_dirty_inodes();
>> +}
>> +
>>  static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages,
>>  			       bool range_cyclic, enum wb_reason reason)
>>  {
>> @@ -942,6 +953,12 @@ static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages,
>>  		return;
>>  
>>  	/*
>> +	 * If someone asked for zero pages, we write out the WORLD
>> +	 */
>> +	if (!nr_pages)
>> +		nr_pages = get_nr_dirty_pages();
>> +
> 
> So for 'wb' we have a better estimate of the amount we should write - use
> wb_stat_sum(wb, WB_RECLAIMABLE) statistics - that is essentially dirty +
> unstable_nfs broken down to bdi_writeback.

I don't mind making that change, but I think that should be a separate
patch. We're using get_nr_dirty_pages() in existing locations where
we have the 'wb', like in wb_check_old_data_flush().

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
  [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback  in laptop mode Jan Kara <jack@suse.cz> - 2017-09-20 16:40 +0200
      Re: [PATCH 3/6] page-writeback: pass in '0' for nr_pages writeback in  laptop mode Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:30 +0200
  [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 2/6] fs-writeback: provide a wakeup_flusher_threads_bdi() Jan Kara <jack@suse.cz> - 2017-09-20 16:30 +0200
  [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one location Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jan Kara <jack@suse.cz> - 2017-09-20 16:50 +0200
      Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:10 +0200
        Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jan Kara <jack@suse.cz> - 2017-09-20 17:40 +0200
          Re: [PATCH 5/6] fs-writeback: move nr_pages == 0 logic to one  location Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:50 +0200
  [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:10 +0200
    Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jan Kara <jack@suse.cz> - 2017-09-20 16:20 +0200
      Re: [PATCH 1/6] buffer: cleanup free_more_memory() flusher wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 17:20 +0200
  [PATCH 6/6] fs-writeback: only allow one inflight and pending !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:00 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Johannes Weiner <hannes@cmpxchg.org> - 2017-09-19 22:20 +0200
      Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-19 22:40 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 04:00 +0200
    Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Amir Goldstein <amir73il@gmail.com> - 2017-09-20 05:20 +0200
      Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 06:20 +0200
        Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Amir Goldstein <amir73il@gmail.com> - 2017-09-20 08:10 +0200
          Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jens Axboe <axboe@kernel.dk> - 2017-09-20 14:40 +0200
        Re: [PATCH 6/6] fs-writeback: only allow one inflight and pending  !nr_pages flush Jan Kara <jack@suse.cz> - 2017-09-20 16:50 +0200
  Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup John Stoffel <john@quad.stoffel.home> - 2017-09-20 21:40 +0200
    Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Jens Axboe <axboe@kernel.dk> - 2017-09-20 21:40 +0200
      Re: [PATCH 0/6] More graceful flusher thread memory reclaim wakeup Johannes Weiner <hannes@cmpxchg.org> - 2017-09-21 01:20 +0200

csiph-web