Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()
Date	2017-09-20 11:20 +0200
Message-ID	<urJkJ-11L-9@gated-at.bofh.it> (permalink)
References	<ur4KB-70P-9@gated-at.bofh.it> <ur4KC-70P-39@gated-at.bofh.it> <urmo9-1TP-1@gated-at.bofh.it> <urHiX-8bg-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Sep 20, 2017 at 09:09:16AM +0200, SF Markus Elfring wrote:
> >> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client,
> >>  	/* initialize the audio */
> >>  	if (write_regs(audio, aud_regs) < 0) {
> >>  		dev_err(&client->dev, "error initializing audio\n");
> >> -		goto fail;
> >> +		goto e_io;
> > 
> > Preserve the error code.
> 
> Do you suggest then to adjust the implementation of the function "write_regs"
> so that a more meaningful value would be used instead of the failure indication "-1"?
> 

If you want to, yeah, that would be good.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/6] [media] go7007: Use common error handling code in  s2250_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-18 16:00 +0200
  Re: [PATCH 4/6] [media] go7007: Use common error handling code in  s2250_probe() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-19 10:50 +0200
    Re: [PATCH 4/6] [media] go7007: Use common error handling code in  s2250_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-20 09:10 +0200
      Re: [PATCH 4/6] [media] go7007: Use common error handling code in  s2250_probe() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-20 11:20 +0200

csiph-web