Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1735578
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() |
| Date | 2017-09-20 09:10 +0200 |
| Message-ID | <urHiX-8bg-59@gated-at.bofh.it> (permalink) |
| References | <ur4KB-70P-9@gated-at.bofh.it> <ur4KC-70P-39@gated-at.bofh.it> <urmo9-1TP-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> @@ -555,17 +553,13 @@ static int s2250_probe(struct i2c_client *client,
>> /* initialize the audio */
>> if (write_regs(audio, aud_regs) < 0) {
>> dev_err(&client->dev, "error initializing audio\n");
>> - goto fail;
>> + goto e_io;
>
> Preserve the error code.
Do you suggest then to adjust the implementation of the function "write_regs"
so that a more meaningful value would be used instead of the failure indication "-1"?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/go7007/s2250-board.c?h=v4.14-rc1#n302
http://elixir.free-electrons.com/linux/v4.14-rc1/source/drivers/media/usb/go7007/s2250-board.c#L298
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-18 16:00 +0200
Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-19 10:50 +0200
Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-20 09:10 +0200
Re: [PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-20 11:20 +0200
csiph-web