Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info

Path	csiph.com!news.mixmin.net!news.unit0.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info
Date	Mon, 18 Sep 2017 16:00:03 +0200
Message-ID	<ur4KD-70P-49@gated-at.bofh.it> (permalink)
References	<uqVnX-wo-1@gated-at.bofh.it> <uqVnY-wo-5@gated-at.bofh.it> <uqVnY-wo-3@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.9.0 (2017-09-02)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com
X-Original-Date	Mon, 18 Sep 2017 15:59:55 +0200
X-Original-Message-ID	<20170918135955.GD21077@kroah.com>
X-Original-References	<20170918034955.10913-1-kys@exchange.microsoft.com> <20170918035419.11062-1-kys@exchange.microsoft.com> <20170918035419.11062-3-kys@exchange.microsoft.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1734161

Show key headers only | View raw

On Sun, Sep 17, 2017 at 08:54:18PM -0700, kys@exchange.microsoft.com wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
> 
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
> 
> The existing sysfs only displayed information about the primary
> channel. The one place it reported multiple channels was the
> channel_vp_mapping file which violated the sysfs convention
> of one value per file.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  Documentation/ABI/stable/sysfs-bus-vmbus |  56 ++++++++++
>  drivers/hv/channel_mgmt.c                |  10 +-
>  drivers/hv/hyperv_vmbus.h                |   2 +
>  drivers/hv/vmbus_drv.c                   | 185 +++++++++++++++++++++++++++++--
>  include/linux/hyperv.h                   |   6 +
>  5 files changed, 246 insertions(+), 13 deletions(-)

Feels like a new feature to me, and not needed in 4.14-final.

thanks,

greg k-h

Thread

[PATCH V2 0/4] Drivers: hv: Miscellaneous fixes  kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
  [PATCH V2 3/4] vmbus: add per-channel sysfs info kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
  [PATCH V2 4/4] Drivers: hv: vmbus: Expose per-channel event counters events counters kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    Re: [PATCH V2 4/4] Drivers: hv: vmbus: Expose per-channel event  counters events counters Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
  [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer length kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
      Re: [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer  length Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
    Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
    Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:10 +0200
      RE: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() KY Srinivasan <kys@microsoft.com> - 2017-09-18 16:50 +0200

csiph-web