Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1734153

Re: [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer length

Show all headers | View raw

On Sun, Sep 17, 2017 at 08:54:17PM -0700, kys@exchange.microsoft.com wrote:
> From: Olaf Hering <olaf@aepfle.de>
> 
> Till recently the expected length of bytes read by the
> daemon did depend on the context. It was either hv_start_fcopy or
> hv_do_fcopy. The daemon had a buffer size of two pages, which was much
> larger than needed.
> 
> Now the expected length of bytes read by the
> daemon changed slightly. For START_FILE_COPY it is still the size of
> hv_start_fcopy.  But for WRITE_TO_FILE and the other operations it is as
> large as the buffer that arrived via vmbus. In case of WRITE_TO_FILE
> that is slightly larger than a struct hv_do_fcopy. Since the buffer in
> the daemon was still larger everything was fine.
> 
> Currently, the daemon reads only what is actually needed.
> The new buffer layout is as large as a struct hv_do_fcopy, for the
> WRITE_TO_FILE operation. Since the kernel expects a slightly larger
> size, hvt_op_read will return -EINVAL because the daemon will read
> slightly less than expected. Address this by restoring the expected
> buffer size in case of WRITE_TO_FILE.
> 
> Fixes: 'commit c7e490fc23eb ("Drivers: hv: fcopy: convert to hv_utils_transport")'
> Fixes: 'commit 3f2baa8a7d2e ("Tools: hv: update buffer handling in hv_fcopy_daemon")'

What's with the 'commit' here?

It should look like:
Fixes: c7e490fc23eb ("Drivers: hv: fcopy: convert to hv_utils_transport")

Please fix...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/4] Drivers: hv: Miscellaneous fixes  kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
  [PATCH V2 3/4] vmbus: add per-channel sysfs info kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    Re: [PATCH V2 3/4] vmbus: add per-channel sysfs info Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
  [PATCH V2 4/4] Drivers: hv: vmbus: Expose per-channel event counters events counters kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    Re: [PATCH V2 4/4] Drivers: hv: vmbus: Expose per-channel event  counters events counters Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
  [PATCH V2 1/4] vmbus: don't acquire the mutex in vmbus_hvsock_device_unregister() kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
    [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer length kys@exchange.microsoft.com - 2017-09-18 06:00 +0200
      Re: [PATCH V2 2/4] Drivers: hv: fcopy: restore correct transfer  length Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
    Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:00 +0200
    Re: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() Greg KH <gregkh@linuxfoundation.org> - 2017-09-18 16:10 +0200
      RE: [PATCH V2 1/4] vmbus: don't acquire the mutex in  vmbus_hvsock_device_unregister() KY Srinivasan <kys@microsoft.com> - 2017-09-18 16:50 +0200

csiph-web