Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731649

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

Show key headers only | View raw

On Wed, Sep 13, 2017 at 07:02:05AM -0700, Jiri Kosina wrote:
> On Fri, 8 Sep 2017, Dmitry Torokhov wrote:
> 
> > From: Adrian Salido <salidoa@google.com>
> > 
> > The buffer allocation is not currently accounting for an extra byte for
> > the report id. This can cause an out of bounds access in function
> > i2c_hid_set_or_send_report() with reportID > 15.
> > 
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Missing signoff from the patch author?

Oops, I must have cut it off on accident while removing ChromeOS
specific tags, the original commit is here:

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

> 
> Also, I think this should have Cc: stable, right?

I usually let maintainers decide, but yes.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 16:10 +0200
  Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-13 17:00 +0200
    Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 17:00 +0200
      Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Benson Leung <bleung@google.com> - 2017-09-13 17:10 +0200

csiph-web