Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731623 > unrolled thread

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 16:10 +0200
    Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-13 17:00 +0200
      Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 17:00 +0200
        Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Benson Leung <bleung@google.com> - 2017-09-13 17:10 +0200

#1731623 — Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

On Fri, 8 Sep 2017, Dmitry Torokhov wrote:

> From: Adrian Salido <salidoa@google.com>
> 
> The buffer allocation is not currently accounting for an extra byte for
> the report id. This can cause an out of bounds access in function
> i2c_hid_set_or_send_report() with reportID > 15.
> 
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Missing signoff from the patch author?

Also, I think this should have Cc: stable, right?

Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]

#1731649

On Wed, Sep 13, 2017 at 07:02:05AM -0700, Jiri Kosina wrote:
> On Fri, 8 Sep 2017, Dmitry Torokhov wrote:
> 
> > From: Adrian Salido <salidoa@google.com>
> > 
> > The buffer allocation is not currently accounting for an extra byte for
> > the report id. This can cause an out of bounds access in function
> > i2c_hid_set_or_send_report() with reportID > 15.
> > 
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Missing signoff from the patch author?

Oops, I must have cut it off on accident while removing ChromeOS
specific tags, the original commit is here:

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

> 
> Also, I think this should have Cc: stable, right?

I usually let maintainers decide, but yes.

Thanks.

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]

#1731653

On Wed, 13 Sep 2017, Dmitry Torokhov wrote:

> > > From: Adrian Salido <salidoa@google.com>
> > > 
> > > The buffer allocation is not currently accounting for an extra byte for
> > > the report id. This can cause an out of bounds access in function
> > > i2c_hid_set_or_send_report() with reportID > 15.
> > > 
> > > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > Missing signoff from the patch author?
> 
> Oops, I must have cut it off on accident while removing ChromeOS
> specific tags, the original commit is here:
> 
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

Ok, thanks, will use that one. How about 

	Reviewed-by: Benson Leung <bleung@chromium.org>

which is missing in the mail you've sent, but is there in the above 
reference commit?

> > Also, I think this should have Cc: stable, right?
> 
> I usually let maintainers decide, but yes.

I'll be adding it. Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1731657

[Multipart message — attachments visible in raw view] — view raw

Hi Jiri,

On Wed, Sep 13, 2017 at 07:52:20AM -0700, Jiri Kosina wrote:
> > Oops, I must have cut it off on accident while removing ChromeOS
> > specific tags, the original commit is here:
> > 
> > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212
> 
> Ok, thanks, will use that one. How about 
> 
> 	Reviewed-by: Benson Leung <bleung@chromium.org>
> 
> which is missing in the mail you've sent, but is there in the above 
> reference commit?

Submission looks good to me. Go ahead and add.
Reviewed-by: Benson Leung <bleung@chromium.org>

Thanks,
Benson
-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web