Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731652

Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

Show all headers | View raw

On Wed, 2017-09-13 at 13:02 +0530, Allen Pais wrote:
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>

I think the changelog for this series of conversions
should show that you've validated the change by
inspecting the return call chain at each modified line.

Also, it seems you've cc'd the same mailing lists for
all of the patches modified by this series.

It would be better to individually address each patch
in the series only cc'ing the appropriate maintainers
and mailing lists.

A cover letter would be good too.

> ---
>  arch/powerpc/platforms/cell/spider-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c
> index d1e61e2..82aa3f7 100644
> --- a/arch/powerpc/platforms/cell/spider-pci.c
> +++ b/arch/powerpc/platforms/cell/spider-pci.c
> @@ -106,7 +106,7 @@ static int __init spiderpci_pci_setup_chip(struct pci_controller *phb,
>  	dummy_page_va = kmalloc(PAGE_SIZE, GFP_KERNEL);
>  	if (!dummy_page_va) {
>  		pr_err("SPIDERPCI-IOWA:Alloc dummy_page_va failed.\n");
> -		return -1;
> +		return -ENOMEM;
>  	}
>  
>  	dummy_page_da = dma_map_single(phb->parent, dummy_page_va,
> @@ -137,7 +137,7 @@ int __init spiderpci_iowa_init(struct iowa_bus *bus, void *data)
>  	if (!priv) {
>  		pr_err("SPIDERPCI-IOWA:"
>  		       "Can't allocate struct spiderpci_iowa_private");
> -		return -1;
> +		return -ENOMEM;
>  	}
>  
>  	if (of_address_to_resource(np, 0, &r)) {

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 08/10] driver:cxgbit: return -NOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 03/10] driver:gpu: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 04/10] drivers:mpt: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
    Re: [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure. David Sterba <dsterba@suse.cz> - 2017-09-13 17:20 +0200
  [PATCH 09/10] driver:video: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
    Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Andrew Lunn <andrew@lunn.ch> - 2017-09-13 14:10 +0200
      Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-13 15:10 +0200
      Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-20 09:20 +0200
  [PATCH 07/10] driver:megaraid: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
  [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
    Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation  failure. Andrew Lunn <andrew@lunn.ch> - 2017-09-13 14:20 +0200
      Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-13 15:10 +0200
      Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-20 09:00 +0200
    Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation  failure. David Miller <davem@davemloft.net> - 2017-09-13 18:30 +0200
  Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Joe Perches <joe@perches.com> - 2017-09-13 17:00 +0200
    Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Allen <allen.lkml@gmail.com> - 2017-09-14 06:50 +0200

csiph-web