Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

Path	csiph.com!goblin1!goblin.stu.neva.ru!border1.nntp.ams1.giganews.com!nntp.giganews.com!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case
Date	Wed, 13 Sep 2017 17:00:02 +0200
Message-ID	<uphiW-e2-13@gated-at.bofh.it> (permalink)
References	<unvJo-1M9-15@gated-at.bofh.it> <upgwy-8oG-15@gated-at.bofh.it> <uphiW-e2-1@gated-at.bofh.it>
X-X-Sender	jkosina@wotan.suse.de
User-Agent	Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Benjamin Tissoires <benjamin.tissoires@redhat.com>, Guenter Roeck <groeck@chromium.org>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 13 Sep 2017 07:52:20 -0700 (PDT)
X-Original-Message-ID	<nycvar.YFH.7.76.1709130751380.4703@jbgna.fhfr.qr>
X-Original-References	<20170908175527.GA19720@dtor-ws> <nycvar.YFH.7.76.1709130701170.4703@jbgna.fhfr.qr> <20170913144950.GA1122@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1731653

Show key headers only | View raw

On Wed, 13 Sep 2017, Dmitry Torokhov wrote:

> > > From: Adrian Salido <salidoa@google.com>
> > > 
> > > The buffer allocation is not currently accounting for an extra byte for
> > > the report id. This can cause an out of bounds access in function
> > > i2c_hid_set_or_send_report() with reportID > 15.
> > > 
> > > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > Missing signoff from the patch author?
> 
> Oops, I must have cut it off on accident while removing ChromeOS
> specific tags, the original commit is here:
> 
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

Ok, thanks, will use that one. How about 

	Reviewed-by: Benson Leung <bleung@chromium.org>

which is missing in the mail you've sent, but is there in the above 
reference commit?

> > Also, I think this should have Cc: stable, right?
> 
> I usually let maintainers decide, but yes.

I'll be adding it. Thanks,

-- 
Jiri Kosina
SUSE Labs

Thread

Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 16:10 +0200
  Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-13 17:00 +0200
    Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Jiri Kosina <jikos@kernel.org> - 2017-09-13 17:00 +0200
      Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case Benson Leung <bleung@google.com> - 2017-09-13 17:10 +0200

csiph-web