[tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	tip-bot for Martin Kepplinger <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:core/urgent] tools/objtool: Fix memory leak in elf_create_rela_section()
Date	Fri, 15 Sep 2017 10:50:01 +0200
Message-ID	<upUtX-mr-9@gated-at.bofh.it> (permalink)
References	<upvvz-1l9-7@gated-at.bofh.it>
Reply-To	dzickus@redhat.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, mingo@kernel.org, tglx@linutronix.de, peterz@infradead.org, hpa@zytor.com, martink@posteo.de, torvalds@linux-foundation.org
Git-Commit-ID	5b1972d74446bed79df5ddc9674bc3f2a0b6c444
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	dzickus@redhat.com, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, peterz@infradead.org, torvalds@linux-foundation.org, martink@posteo.de
X-Original-Date	Fri, 15 Sep 2017 01:43:33 -0700
X-Original-Message-ID	<tip-5b1972d74446bed79df5ddc9674bc3f2a0b6c444@git.kernel.org>
X-Original-References	<20170914060138.26472-1-martink@posteo.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1732783

Show key headers only | View raw

Commit-ID:  5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Gitweb:     http://git.kernel.org/tip/5b1972d74446bed79df5ddc9674bc3f2a0b6c444
Author:     Martin Kepplinger <martink@posteo.de>
AuthorDate: Thu, 14 Sep 2017 08:01:38 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 15 Sep 2017 10:30:30 +0200

tools/objtool: Fix memory leak in elf_create_rela_section()

Let's free the allocated char array 'relaname' before returning,
in order to avoid leaking memory.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Reviewed-by: Don Zickus <dzickus@redhat.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo.kernel.org@gmail.com
Link: http://lkml.kernel.org/r/20170914060138.26472-1-martink@posteo.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 tools/objtool/elf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980..1e89a5f 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,6 +508,7 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
+	free(relaname);
 	if (!sec)
 		return NULL;

Thread

[PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-14 00:50 +0200
  Re: [PATCH] tools: objtool: fix memory leak in  elf_create_rela_section() Ingo Molnar <mingo@kernel.org> - 2017-09-14 07:40 +0200
    [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section() Martin Kepplinger <martink@posteo.de> - 2017-09-14 08:10 +0200
      Re: [PATCH v2] tools: objtool: fix memory leak in  elf_create_rela_section() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-14 15:00 +0200
      [tip:core/urgent] tools/objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-14 16:20 +0200
      [tip:core/urgent] tools/objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-15 10:50 +0200
      [tip:core/urgent] objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-15 11:50 +0200

csiph-web