Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1731966

[PATCH] tools: objtool: fix memory leak in elf_create_rela_section()

Show all headers | View raw

From: Martin Kepplinger <martink@posteo.de>

Let's free the allocated char array relaname before returning
in order to avoid leaking memory.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 tools/objtool/elf.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index 6e9f980a7d26..6aacbc31316d 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -508,8 +508,12 @@ struct section *elf_create_rela_section(struct elf *elf, struct section *base)
 	strcat(relaname, base->name);
 
 	sec = elf_create_section(elf, relaname, sizeof(GElf_Rela), 0);
-	if (!sec)
+	if (!sec) {
+		free(relaname);
 		return NULL;
+	}
+
+	free(relaname);
 
 	base->rela = sec;
 	sec->base = base;
-- 
2.13.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tools: objtool: fix memory leak in elf_create_rela_section() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-14 00:50 +0200
  Re: [PATCH] tools: objtool: fix memory leak in  elf_create_rela_section() Ingo Molnar <mingo@kernel.org> - 2017-09-14 07:40 +0200
    [PATCH v2] tools: objtool: fix memory leak in elf_create_rela_section() Martin Kepplinger <martink@posteo.de> - 2017-09-14 08:10 +0200
      Re: [PATCH v2] tools: objtool: fix memory leak in  elf_create_rela_section() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-14 15:00 +0200
      [tip:core/urgent] tools/objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-14 16:20 +0200
      [tip:core/urgent] tools/objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-15 10:50 +0200
      [tip:core/urgent] objtool: Fix memory leak in  elf_create_rela_section() tip-bot for Martin Kepplinger <tipbot@zytor.com> - 2017-09-15 11:50 +0200

csiph-web