Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1732490

[PATCH] crypto: algboss: remove redundant setting of len to zero

From Colin King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] crypto: algboss: remove redundant setting of len to zero
Date 2017-09-14 20:10 +0200
Message-ID <upGKm-8qu-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


From: Colin Ian King <colin.king@canonical.com>

The variable len is set to zero, never read and then later updated
to p - name, so clearly the zero'ing of len is redundant and
can be removed.

Detected by clang scan-build:
" warning: Value stored to 'len' is never read"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 crypto/algboss.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 960d8548171b..5e6df2a087fa 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -122,7 +122,6 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
 		int notnum = 0;
 
 		name = ++p;
-		len = 0;
 
 		for (; isalnum(*p) || *p == '-' || *p == '_'; p++)
 			notnum |= !isdigit(*p);
-- 
2.14.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] crypto: algboss: remove redundant setting of len to zero Colin King <colin.king@canonical.com> - 2017-09-14 20:10 +0200

csiph-web