Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730184

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

Show all headers | View raw

Hi,

On Saturday 09 September 2017 09:39 AM, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Fri, 8 Sep 2017 13:31:37 +0300
> 
>> devm_ioremap_resource() never returns NULL, it only returns error
>> pointers so this test needs to be changed.
>>
>> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> This driver apparently is going through the net tree, but netdev isn't
>> listed as handling it in MAINTAINERS.  Kishon, do you know what's up
>> with that?

I've reviewed this driver and sometimes the PHY drivers gets merged along with
their consumer driver (In this case mvpp2 ethernet driver). But after it's
merged, all further fixes and features go via linux-phy tree (mostly).
> 
> Yeah let's sort this out before I apply this fix to my tree.

I'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with you.

Thanks
Kishon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 12:40 +0200
  Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of  IS_ERR() David Miller <davem@davemloft.net> - 2017-09-09 06:10 +0200
    Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of  IS_ERR() Kishon Vijay Abraham I <kishon@ti.com> - 2017-09-11 09:30 +0200
      Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of  IS_ERR() David Miller <davem@davemloft.net> - 2017-09-11 19:30 +0200

csiph-web