Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1729381

Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()
Date 2017-09-09 06:10 +0200
Message-ID <unFfI-7P-5@gated-at.bofh.it> (permalink)
References <unoRA-5F0-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 8 Sep 2017 13:31:37 +0300

> devm_ioremap_resource() never returns NULL, it only returns error
> pointers so this test needs to be changed.
> 
> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This driver apparently is going through the net tree, but netdev isn't
> listed as handling it in MAINTAINERS.  Kishon, do you know what's up
> with that?

Yeah let's sort this out before I apply this fix to my tree.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR() Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-08 12:40 +0200
  Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of  IS_ERR() David Miller <davem@davemloft.net> - 2017-09-09 06:10 +0200

csiph-web