RE: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree
Date	2017-09-08 17:10 +0200
Message-ID	<unt4S-jD-31@gated-at.bofh.it> (permalink)
References	<ujxTr-16C-5@gated-at.bofh.it> <ujxTr-16C-13@gated-at.bofh.it> <unt4S-jD-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vivien Didelot
> Sent: 08 September 2017 15:57
...
> > > Also more important, you will notice what seems to be a bug to me:
> > > I can read or write a file even if I didn't mask the corresponding mode
> > > hence the double check in dsa_debugfs_show and dsa_debugfs_write.
> >
> > The mode can be changed by userspace, you shouldn't ever need to check
> > it in any debugfs calls, right?
> 
> Correct. But this happens even if the file mode isn't changed by
> userspace in the meantime, which seemed weird to me. e.g. echo
> redirected to a -r--r--r-- debugfs entry will call dsa_debugfs_write.

root will be able to write using 'root' permissions, regardless of
the directory entry.

	David

Thread

[PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-28 21:30 +0200
  Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 16:30 +0200
    Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 16:50 +0200
  Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 17:10 +0200
    RE: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree David Laight <David.Laight@ACULAB.COM> - 2017-09-08 17:10 +0200
    Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 17:30 +0200

csiph-web