Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree
Date	2017-09-08 16:50 +0200
Message-ID	<unsLw-8nP-9@gated-at.bofh.it> (permalink)
References	<ujxTr-16C-5@gated-at.bofh.it> <ujxTr-16C-13@gated-at.bofh.it> <unss9-8fk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 08, 2017 at 10:18:27AM -0400, Vivien Didelot wrote:
> Hi Greg,
> 
> Can I ask for a quick review of this patch as well? It's the one adding
> the boilerplate for a single debugfs file, and I'm pretty sure it can be
> reduced somehow.

I don't see a patch here :(

> Also more important, you will notice what seems to be a bug to me:
> I can read or write a file even if I didn't mask the corresponding mode,
> hence the double check in dsa_debugfs_show and dsa_debugfs_write.

The mode can be changed by userspace, you shouldn't ever need to check
it in any debugfs calls, right?

thanks,

greg k-h

Thread

[PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-08-28 21:30 +0200
  Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 16:30 +0200
    Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 16:50 +0200
  Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-09-08 17:10 +0200
    RE: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree David Laight <David.Laight@ACULAB.COM> - 2017-09-08 17:10 +0200
    Re: [PATCH net-next v2 02/10] net: dsa: debugfs: add tree Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-09-08 17:30 +0200

csiph-web