Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729006

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

Show all headers | View raw

Hi Maxime,

On 08/09/17 15:39, Maxime Ripard wrote:
> Hi,
> 
> On Mon, Sep 04, 2017 at 09:14:52AM +0100, André Przywara wrote:
>>> And obviously, while maintaining the stability of the binding of those
>>> hundreds properties.
>>>
>>> Or, you can base all this on the compatible, and be done with it once
>>> and for all.
>>
>> What I am after is to cover SoCs which *don't* have differences in their
>> register layout, for instance A83T, H3, A64, R40.
>> In an ideal world we could have reused the H3 compatible string,
>> adjusting the number of channels for each SoC in the DT.
>>
>> So I see that having a generic compatible name will not fly, as we now
>> have differences which should not be modelled by DT properties.
>> But I still think we should try to cover those non-register differences
>> (number of channels) with a DT property, to allow reusing the existing
>> driver code whenever possible. As is stands with this series, the R40
>> support should just be a matter of:
>> 	compatible = "allwinner,sun8i-r40-dma",
>> 		     "allwinner,sun50i-a64-dma";
> 
> I just suggested the exact same thing, and then saw your mail, so I
> guess we have an agreement :)

Yes, I was thinking so as well.
Since my DeLorean is in the garage ;-) we have no other choice than
doing so.
My original suggestion for a generic name was based on my naive reading
of the existing code, which *looked like* it would be all compatible.
But as we know better now, this is the way to go.

Merci,
André

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] dmaengine: Fix DMA on current allwinner SoCs, add A64 support Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
  [PATCH 2/3] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
  [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Code Kipper <codekipper@gmail.com> - 2017-08-31 13:50 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-31 17:00 +0200
      Re: [linux-sunxi] Re: [PATCH 3/3] dmaengine: sun6i: Add support for  Allwinner A64 Code Kipper <codekipper@gmail.com> - 2017-08-31 18:40 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Andre Przywara <andre.przywara@arm.com> - 2017-09-01 02:40 +0200
      Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-01 03:30 +0200
        Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-02 00:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-02 02:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-02 04:10 +0200
            Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-04 01:20 +0200
      Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 08:10 +0200
        Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-02 00:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-04 09:10 +0200
            Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-04 10:20 +0200
              Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-08 16:40 +0200
                Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Andre Przywara <andre.przywara@arm.com> - 2017-09-08 17:00 +0200
  [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
    Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-31 17:00 +0200
      Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-01 05:10 +0200
        Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 15:40 +0200
          Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Brüns, Stefan <Stefan.Bruens@rwth-aachen.de> - 2017-09-01 16:50 +0200
            Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-04 09:00 +0200

csiph-web