Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725419

Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64

Show all headers | View raw

On Samstag, 2. September 2017 00:32:50 CEST André Przywara wrote:
> Hi,
> 
> On 01/09/17 02:19, Stefan Bruens wrote:
> > On Freitag, 1. September 2017 02:31:35 CEST Andre Przywara wrote:
> >> Hi,
> >> 
> >> On 31/08/17 00:36, Stefan Brüns wrote:
> >>> The A64 SoC has the same dma engine as the H3 (sun8i), with a
> >>> reduced amount of physical channels. Add the proper config data
> >>> and compatible string to support it.
> >> 
> >> ...
> >> 
> >>> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> >>> index 5f4eee4513e5..6a17c5d63582 100644
> >>> --- a/drivers/dma/sun6i-dma.c
> >>> +++ b/drivers/dma/sun6i-dma.c
> >>> @@ -1068,6 +1068,12 @@ static struct sun6i_dma_config sun8i_h3_dma_cfg =
> >>> {
> >>> 
> >>>  	.nr_max_vchans   = 34,
> >>>  	.dmac_variant    = DMAC_VARIANT_H3,
> >>>  
> >>>  };
> >>> 
> >>> +
> >>> +static struct sun6i_dma_config sun50i_a64_dma_cfg = {
> >>> +	.nr_max_channels = 8,
> >>> +	.nr_max_requests = 27,
> >>> +	.nr_max_vchans   = 38,
> >>> +	.dmac_variant    = DMAC_VARIANT_H3,
> >>> 
> >>>  };
> >>>  
[...]
> > There are also the incompatibilities in the "DMA channel configuration
> > register" (burst length; burst width; burst length field offset).
> > 
> > We can either have 3 different compatible strings, or another property for
> > the register model.
> 
> The latter is usually frowned upon, using separate compatible strings
> for each group of SoCs is the way to go here.

Just for clarification, I was not talking about a property in the devicetree, 
but about a struct member in the config data, i.e. the .dmac_variant above.

Kind regards,

Stefan

-- 
Stefan Brüns  /  Bergstraße 21  /  52062 Aachen
home: +49 241 53809034     mobile: +49 151 50412019

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] dmaengine: Fix DMA on current allwinner SoCs, add A64 support Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
  [PATCH 2/3] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
  [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Code Kipper <codekipper@gmail.com> - 2017-08-31 13:50 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-31 17:00 +0200
      Re: [linux-sunxi] Re: [PATCH 3/3] dmaengine: sun6i: Add support for  Allwinner A64 Code Kipper <codekipper@gmail.com> - 2017-08-31 18:40 +0200
    Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Andre Przywara <andre.przywara@arm.com> - 2017-09-01 02:40 +0200
      Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-01 03:30 +0200
        Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-02 00:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-02 02:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-02 04:10 +0200
            Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-04 01:20 +0200
      Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 08:10 +0200
        Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-02 00:40 +0200
          Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-04 09:10 +0200
            Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 André Przywara <andre.przywara@arm.com> - 2017-09-04 10:20 +0200
              Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-08 16:40 +0200
                Re: [PATCH 3/3] dmaengine: sun6i: Add support for Allwinner A64 Andre Przywara <andre.przywara@arm.com> - 2017-09-08 17:00 +0200
  [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Stefan Brüns <stefan.bruens@rwth-aachen.de> - 2017-08-31 01:40 +0200
    Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-08-31 17:00 +0200
      Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Stefan Bruens <stefan.bruens@rwth-aachen.de> - 2017-09-01 05:10 +0200
        Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-01 15:40 +0200
          Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Brüns, Stefan <Stefan.Bruens@rwth-aachen.de> - 2017-09-01 16:50 +0200
            Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-04 09:00 +0200

csiph-web