Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728627
| From | Jonathan Cameron <jic23@jic23.retrosnub.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging: iio: adc: Added Space around binary op. |
| Date | 2017-09-08 08:30 +0200 |
| Message-ID | <unkXE-2YQ-7@gated-at.bofh.it> (permalink) |
| References | <unjoR-1Us-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 8 September 2017 05:47:52 BST, Himanshi Jain <himshijain.hj@gmail.com> wrote: >Added space around(one on each side of) binary >operator(-) as preferred according to kernel >coding style. > >Signed-off-by: Himanshi Jain <himshijain.hj@gmail.com> Take a closer look at that macro. It isn't doing what you think... To give a hint, changing this breaks userspace. Jonathan >--- > drivers/staging/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/iio/adc/ad7192.c >b/drivers/staging/iio/adc/ad7192.c >index d11c6de..1aee662 100644 >--- a/drivers/staging/iio/adc/ad7192.c >+++ b/drivers/staging/iio/adc/ad7192.c >@@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st, > } > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, >- in_voltage-voltage_scale_available, >+ in_voltage - voltage_scale_available, > 0444, ad7192_show_scale_available, NULL, 0); > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Staging: iio: adc: Added Space around binary op. Himanshi Jain <himshijain.hj@gmail.com> - 2017-09-08 06:50 +0200
Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 08:10 +0200
Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-09-08 08:30 +0200
Re: [PATCH] Staging: iio: adc: Added Space around binary op. Lars-Peter Clausen <lars@metafoo.de> - 2017-09-08 11:40 +0200
Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-08 11:50 +0200
Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 12:10 +0200
Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op. Lars-Peter Clausen <lars@metafoo.de> - 2017-09-08 12:20 +0200
Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space around binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 12:40 +0200
Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-08 11:40 +0200
csiph-web