Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728620

Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op.

Show all headers | View raw

On Fri, 8 Sep 2017, Himanshi Jain wrote:

> Added space around(one on each side of) binary

I think that just around would be clear enough.

In the previous patches on this file, found with git log --oneline, a
subject line of staging: iio: ad7192: seems to be more popular when the
patch affects only this file.  But maybe it doesn't matter either way.

julia

> operator(-) as preferred according to kernel
> coding style.
>
> Signed-off-by: Himanshi Jain <himshijain.hj@gmail.com>
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index d11c6de..1aee662 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st,
>  }
>
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -			     in_voltage-voltage_scale_available,
> +			     in_voltage - voltage_scale_available,
>  			     0444, ad7192_show_scale_available, NULL, 0);
>
>  static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908044752.GA6199%40himanshi-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: iio: adc: Added Space around binary op. Himanshi Jain <himshijain.hj@gmail.com> - 2017-09-08 06:50 +0200
  Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around  binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 08:10 +0200
  Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-09-08 08:30 +0200
    Re: [PATCH] Staging: iio: adc: Added Space around binary op. Lars-Peter Clausen <lars@metafoo.de> - 2017-09-08 11:40 +0200
      Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-08 11:50 +0200
      Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space  around binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 12:10 +0200
        Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space  around binary op. Lars-Peter Clausen <lars@metafoo.de> - 2017-09-08 12:20 +0200
          Re: [Outreachy kernel] Re: [PATCH] Staging: iio: adc: Added Space  around binary op. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-08 12:40 +0200
    Re: [PATCH] Staging: iio: adc: Added Space around binary op. Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-08 11:40 +0200

csiph-web