Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1728232
| Path | csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Colin Ian King <colin.king@canonical.com> |
| Newsgroups | linux.kernel |
| Subject | NACK: [PATCH] tpm_tis: unconstify array cmd_getticks |
| Date | Thu, 07 Sep 2017 16:10:02 +0200 |
| Message-ID | <un5Fg-To-11@gated-at.bofh.it> (permalink) |
| References | <un0FA-5YE-7@gated-at.bofh.it> |
| X-Original-To | Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com>, tpmdd-devel@lists.sourceforge.net |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 36 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 7 Sep 2017 15:02:32 +0100 |
| X-Original-Message-ID | <4c4d2976-3c24-528b-605d-a8dfcdd8439f@canonical.com> |
| X-Original-References | <20170907084245.19513-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1728232 |
Show key headers only | View raw
On 07/09/17 09:42, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove const from cmd_getticks, fixes build warnings:
>
> drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of
> 'tpm_tis_send_data' discards 'const' qualifier from pointer target
> type [-Wdiscarded-qualifiers]
> rc = tpm_tis_send_data(chip, cmd_getticks, len);
> ^
> drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of
> 'tpm_tis_send_data' discards 'const' qualifier from pointer target
> type [-Wdiscarded-qualifiers]
> rc = tpm_tis_send_data(chip, cmd_getticks, len);
> ^
> Fixes: 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/tpm/tpm_tis_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 1e957e923d21..91cf38be314f 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -445,7 +445,7 @@ static int probe_itpm(struct tpm_chip *chip)
> {
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
> int rc = 0;
> - static const u8 cmd_getticks[] = {
> + static u8 cmd_getticks[] = {
> 0x00, 0xc1, 0x00, 0x00, 0x00, 0x0a,
> 0x00, 0x00, 0x00, 0xf1
> };
>
Ignore this, seems like Arnd Bergmann has fixed this properly.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] tpm_tis: unconstify array cmd_getticks Colin King <colin.king@canonical.com> - 2017-09-07 10:50 +0200
NACK: [PATCH] tpm_tis: unconstify array cmd_getticks Colin Ian King <colin.king@canonical.com> - 2017-09-07 16:10 +0200
Re: NACK: [PATCH] tpm_tis: unconstify array cmd_getticks Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-07 18:30 +0200
csiph-web