Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728041

[PATCH] tpm_tis: unconstify array cmd_getticks

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

Remove const from cmd_getticks, fixes build warnings:

drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of
'tpm_tis_send_data' discards 'const' qualifier from pointer target
type [-Wdiscarded-qualifiers]
  rc = tpm_tis_send_data(chip, cmd_getticks, len);
                               ^
drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of
'tpm_tis_send_data' discards 'const' qualifier from pointer target
type [-Wdiscarded-qualifiers]
  rc = tpm_tis_send_data(chip, cmd_getticks, len);
                               ^
Fixes: 5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/char/tpm/tpm_tis_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 1e957e923d21..91cf38be314f 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -445,7 +445,7 @@ static int probe_itpm(struct tpm_chip *chip)
 {
 	struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
 	int rc = 0;
-	static const u8 cmd_getticks[] = {
+	static u8 cmd_getticks[] = {
 		0x00, 0xc1, 0x00, 0x00, 0x00, 0x0a,
 		0x00, 0x00, 0x00, 0xf1
 	};
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm_tis: unconstify array cmd_getticks Colin King <colin.king@canonical.com> - 2017-09-07 10:50 +0200
  NACK: [PATCH] tpm_tis: unconstify array cmd_getticks Colin Ian King <colin.king@canonical.com> - 2017-09-07 16:10 +0200
    Re: NACK: [PATCH] tpm_tis: unconstify array cmd_getticks Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-07 18:30 +0200

csiph-web