Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1728042

Re: linux-next: build warning after merge of the tpmdd tree

From Colin Ian King <colin.king@canonical.com>
Newsgroups linux.kernel
Subject Re: linux-next: build warning after merge of the tpmdd tree
Date 2017-09-07 10:50 +0200
Message-ID <un0FA-5YE-11@gated-at.bofh.it> (permalink)
References <umUTw-233-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Thanks for reporting that Stephen, I've sent a fix to address this issue.

Colin

On 07/09/17 03:31, Stephen Rothwell wrote:
> Hi Jarkko,
> 
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   rc = tpm_tis_send_data(chip, cmd_getticks, len);
>                                ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
>  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
>             ^
> drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   rc = tpm_tis_send_data(chip, cmd_getticks, len);
>                                ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
>  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
>             ^
> 
> Introduced by commit
> 
>   5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

linux-next: build warning after merge of the tpmdd tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-09-07 04:40 +0200
  Re: linux-next: build warning after merge of the tpmdd tree Colin Ian King <colin.king@canonical.com> - 2017-09-07 10:50 +0200
    Re: linux-next: build warning after merge of the tpmdd tree Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-09-07 18:30 +0200

csiph-web