Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB
Date	2017-09-05 14:30 +0200
Message-ID	<uml9o-2zD-5@gated-at.bofh.it> (permalink)
References	<umgW6-8kA-11@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Arnd,

> Without CONFIG_BLK_DEV_BSGLIB, we get a link error here:
>
> drivers/scsi/scsi_transport_sas.o: In function `sas_bsg_initialize':
> scsi_transport_sas.c:(.text+0xcc0): undefined reference to `bsg_setup_queue'
> scsi_transport_sas.c:(.text+0xd10): undefined reference to `bsg_setup_queue'
> drivers/scsi/scsi_transport_sas.o: In function `sas_smp_dispatch':
> scsi_transport_sas.c:(.text+0xe8c): undefined reference to `bsg_job_done'
>
> This modifies the Kconfig 'select' statement accordingly, and matching
> what we do for the other two scsi_transport implementations that use
> bsglib.
>
> Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to 4.14/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Arnd Bergmann <arnd@arndb.de> - 2017-09-05 10:00 +0200
  Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB Christoph Hellwig <hch@lst.de> - 2017-09-05 13:30 +0200
  Re: [PATCH] scsi: scsi_transport_sas: select BLK_DEV_BSGLIB "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-09-05 14:30 +0200

csiph-web