Re: [PATCH v7 00/19] simplify crypto wait for async op

From	Gilad Ben-Yossef <gilad@benyossef.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 00/19] simplify crypto wait for async op
Date	2017-09-05 14:20 +0200
Message-ID	<umkZH-2wz-7@gated-at.bofh.it> (permalink)
References	<ui19g-7EU-7@gated-at.bofh.it> <ukwVk-5Dr-23@gated-at.bofh.it> <ulwqe-4Q7-3@gated-at.bofh.it> <umkdj-21X-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 5, 2017 at 2:23 PM, Harsh Jain <harshjain.prof@gmail.com> wrote:
> On Sun, Sep 3, 2017 at 11:47 AM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
>> On Thu, Aug 31, 2017 at 3:31 PM, Harsh Jain <harshjain.prof@gmail.com> wrote:
>>> HI Gilad,
>>>
>>> I think we need an update in ESP also. Now EBUSY return means driver
>>> has accepted, Packet should not be dropped in
>>>
>>> esp_output_tail() function.
>>
>> Good catch. You are right and the same holds true for ah_output() in ah4.c.
>>
>> But I do wonder, the code there now treats -EBUSY as a special case
>> and returns NET_XMIT_DROP
>> but if an AEAD or AHASH transformation return some other error, like
>> -ENOMEM or -EINVAL shouldn't
>> we return NET_XMIT_DROP in that case too?
> I think we should not,  XMIT_DROP implies drop current packet only,
> later on when device is recovered from busy state, Upper layer
> protocol(TCP) will re-transmit the packet. It helps in flow control.
>>

I see. Makes sense.

Thanks,
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 00/19] simplify crypto wait for async op Harsh Jain <harshjain.prof@gmail.com> - 2017-08-31 14:40 +0200
  Re: [PATCH v7 00/19] simplify crypto wait for async op Gilad Ben-Yossef <gilad@benyossef.com> - 2017-09-03 08:20 +0200
    Re: [PATCH v7 00/19] simplify crypto wait for async op Harsh Jain <harshjain.prof@gmail.com> - 2017-09-05 13:30 +0200
      Re: [PATCH v7 00/19] simplify crypto wait for async op Gilad Ben-Yossef <gilad@benyossef.com> - 2017-09-05 14:20 +0200

csiph-web