Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush
Date	2017-09-05 10:20 +0200
Message-ID	<umhft-el-35@gated-at.bofh.it> (permalink)
References	<umbMJ-5d5-5@gated-at.bofh.it> <umbMJ-5d5-3@gated-at.bofh.it> <umgt5-8b3-59@gated-at.bofh.it> <umgCJ-8ei-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 05, 2017 at 04:36:18PM +0900, �ں�ö/���ӿ�����/SW Platform(��)AOT��(byungchul.park@lge.com) wrote:
> > -----Original Message-----
> > From: Peter Zijlstra [mailto:peterz@infradead.org]
> > Sent: Tuesday, September 05, 2017 4:26 PM
> > To: Byungchul Park
> > Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org;
> > tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux-
> > kernel@vger.kernel.org; kernel-team@lge.com
> > Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> > workqueue flush
> > 
> > On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
> > 
> > > Also, lock_map_acquire() in process_one_work() is too strong for that
> > > purpose. lock_map_acquire_might() is enough. Replaced it.
> > 
> > NAK!! traditional annotations are superior to cross-release. They are not
> > timing dependent.
> 
> You seem to mis-understand this. This also make them timing independent.
> I also agree that we need timing independent report in workqueue code.
> That's actually why I propose this patch.

Then clearly it needs comments and changelog to explain how it does
things.

Thread

[PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park <byungchul.park@lge.com> - 2017-09-05 04:30 +0200
  Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Peter Zijlstra <peterz@infradead.org> - 2017-09-05 09:30 +0200
    RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)          <byungchul.park@lge.com> - 2017-09-05 09:40 +0200
      Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Peter Zijlstra <peterz@infradead.org> - 2017-09-05 10:20 +0200
      Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Byungchul Park <byungchul.park@lge.com> - 2017-09-05 10:30 +0200

csiph-web