Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726479

RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush

Show all headers | View raw

> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Tuesday, September 05, 2017 4:26 PM
> To: Byungchul Park
> Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org;
> tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux-
> kernel@vger.kernel.org; kernel-team@lge.com
> Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> workqueue flush
> 
> On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
> 
> > Also, lock_map_acquire() in process_one_work() is too strong for that
> > purpose. lock_map_acquire_might() is enough. Replaced it.
> 
> NAK!! traditional annotations are superior to cross-release. They are not
> timing dependent.

You seem to mis-understand this. This also make them timing independent.
I also agree that we need timing independent report in workqueue code.
That's actually why I propose this patch.

I just tried to do it in a right way.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park <byungchul.park@lge.com> - 2017-09-05 04:30 +0200
  Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Peter Zijlstra <peterz@infradead.org> - 2017-09-05 09:30 +0200
    RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)          <byungchul.park@lge.com> - 2017-09-05 09:40 +0200
      Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Peter Zijlstra <peterz@infradead.org> - 2017-09-05 10:20 +0200
      Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt  workqueue flush Byungchul Park <byungchul.park@lge.com> - 2017-09-05 10:30 +0200

csiph-web