Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726486

Re: [PATCH] mm, sparse: fix typo in online_mem_sections

Show all headers | View raw

On Tue 05-09-17 09:28:36, Michal Hocko wrote:
> On Tue 05-09-17 12:32:28, Anshuman Khandual wrote:
> > On 09/04/2017 04:52 PM, Michal Hocko wrote:
> > > From: Michal Hocko <mhocko@suse.com>
> > > 
> > > online_mem_sections accidentally marks online only the first section in
> > > the given range. This is a typo which hasn't been noticed because I
> > > haven't tested large 2GB blocks previously. All users of
> > 
> > Section sizes are normally less than 2GB. Could you please elaborate
> > why this never got noticed before ?
> 
> Section size is 128MB which is the default block size as well. So we
> have one section per block. But if the amount of memory is very large
> (64GB - see probe_memory_block_size) then we have a 2GB memory blocks
> so multiple sections per block.

And just to clarify. Not that 64G would be too large but the original
patch has been merged in 4.13 so nobody probably managed to hit that
_yet_.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-04 13:30 +0200
  Re: [PATCH] mm, sparse: fix typo in online_mem_sections Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-09-05 09:10 +0200
    Re: [PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-05 09:30 +0200
      Re: [PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-05 09:40 +0200
        Re: [PATCH] mm, sparse: fix typo in online_mem_sections Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-09-05 10:50 +0200
  Re: [PATCH] mm, sparse: fix typo in online_mem_sections Vlastimil Babka <vbabka@suse.cz> - 2017-09-06 10:20 +0200

csiph-web