Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726009

[PATCH] mm, sparse: fix typo in online_mem_sections

Show all headers | View raw

From: Michal Hocko <mhocko@suse.com>

online_mem_sections accidentally marks online only the first section in
the given range. This is a typo which hasn't been noticed because I
haven't tested large 2GB blocks previously. All users of
pfn_to_online_page would get confused on the the rest of the pfn range
in the block.

All we need to fix this is to use iterator (pfn) rather than start_pfn.

Fixes: 2d070eab2e82 ("mm: consider zone which is not fully populated to have holes")
Cc: stable
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 mm/sparse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/sparse.c b/mm/sparse.c
index a9783acf2bb9..83b3bf6461af 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -626,7 +626,7 @@ void online_mem_sections(unsigned long start_pfn, unsigned long end_pfn)
 	unsigned long pfn;
 
 	for (pfn = start_pfn; pfn < end_pfn; pfn += PAGES_PER_SECTION) {
-		unsigned long section_nr = pfn_to_section_nr(start_pfn);
+		unsigned long section_nr = pfn_to_section_nr(pfn);
 		struct mem_section *ms;
 
 		/* onlining code should never touch invalid ranges */
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-04 13:30 +0200
  Re: [PATCH] mm, sparse: fix typo in online_mem_sections Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-09-05 09:10 +0200
    Re: [PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-05 09:30 +0200
      Re: [PATCH] mm, sparse: fix typo in online_mem_sections Michal Hocko <mhocko@kernel.org> - 2017-09-05 09:40 +0200
        Re: [PATCH] mm, sparse: fix typo in online_mem_sections Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-09-05 10:50 +0200
  Re: [PATCH] mm, sparse: fix typo in online_mem_sections Vlastimil Babka <vbabka@suse.cz> - 2017-09-06 10:20 +0200

csiph-web