Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg

From	Ethan Zhao <ethan.zhao@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg
Date	2017-09-07 06:30 +0200
Message-ID	<umWBX-3bm-5@gated-at.bofh.it> (permalink)
References	<ulazn-81X-1@gated-at.bofh.it> <ulUiR-2F5-11@gated-at.bofh.it> <ulUsz-2Ip-27@gated-at.bofh.it> <umOEr-6jL-25@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw


On 2017/9/7 3:50, Luis R. Rodriguez wrote:
> On Mon, Sep 04, 2017 at 03:54:23PM +0800, Ethan Zhao wrote:
>> Peter,
>>
>>
>> On 2017/9/4 15:49, Peter Zijlstra wrote:
>>> On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote:
>>>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>>>> index 6648fbb..609bed2 100644
>>>> --- a/kernel/sysctl.c
>>>> +++ b/kernel/sysctl.c
>>>> @@ -367,7 +367,7 @@ static int sysrq_sysctl_handler(struct ctl_table *table, int write,
>>>>    		.data		= &sysctl_sched_time_avg,
>>>>    		.maxlen		= sizeof(unsigned int),
>>>>    		.mode		= 0644,
>>>> -		.proc_handler	= proc_dointvec,
>>>> +		.proc_handler	= sched_time_avg_handler,
>>> *sigh*, what's wrong with the below? Too easy?
>>   :),  seems I walked zigzag several cycles to get the right point.
> It sounds like negative values are not possible too, right? If so then
> you can use proc_douintvec_minmax().
  V4 has been sent days ago, please see v4.

  Thank,
  Ethan
>
>    Luis
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-02 09:00 +0200
  Re: [PATCH v2] sched: check user input value of  sysctl_sched_time_avg Mike Galbraith <efault@gmx.de> - 2017-09-02 09:20 +0200
  Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Peter Zijlstra <peterz@infradead.org> - 2017-09-04 09:50 +0200
    Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-04 10:00 +0200
      Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-06 22:00 +0200
        Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-07 06:30 +0200

csiph-web