Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725898
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg |
| Date | 2017-09-04 09:50 +0200 |
| Message-ID | <ulUiR-2F5-11@gated-at.bofh.it> (permalink) |
| References | <ulazn-81X-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 02, 2017 at 02:57:32PM +0800, Ethan Zhao wrote:
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 6648fbb..609bed2 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -367,7 +367,7 @@ static int sysrq_sysctl_handler(struct ctl_table *table, int write,
> .data = &sysctl_sched_time_avg,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = sched_time_avg_handler,
*sigh*, what's wrong with the below? Too easy?
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 6648fbbb8157..bbbc6a17c15e 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -367,7 +367,8 @@ static struct ctl_table kern_table[] = {
.data = &sysctl_sched_time_avg,
.maxlen = sizeof(unsigned int),
.mode = 0644,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_dointvec_min_max,
+ .extra1 = &one,
},
#ifdef CONFIG_SCHEDSTATS
{
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-02 09:00 +0200
Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Mike Galbraith <efault@gmx.de> - 2017-09-02 09:20 +0200
Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Peter Zijlstra <peterz@infradead.org> - 2017-09-04 09:50 +0200
Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-04 10:00 +0200
Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-09-06 22:00 +0200
Re: [PATCH v2] sched: check user input value of sysctl_sched_time_avg Ethan Zhao <ethan.zhao@oracle.com> - 2017-09-07 06:30 +0200
csiph-web