Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup
Date	Thu, 07 Sep 2017 04:40:02 +0200
Message-ID	<umUTw-233-9@gated-at.bofh.it> (permalink)
References	<ujiUp-f2-5@gated-at.bofh.it> <ujiUq-f2-15@gated-at.bofh.it> <umA8p-4yB-1@gated-at.bofh.it> <umB4t-5b7-7@gated-at.bofh.it> <umBnP-5iy-9@gated-at.bofh.it> <umDzj-7di-7@gated-at.bofh.it> <umUJP-1ZS-1@gated-at.bofh.it>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com F1B68859F7
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=bhe@redhat.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.0 (2016-08-17)
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.12
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 07 Sep 2017 02:34:24 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, rjw@rjwysocki.net, bp@alien8.de, indou.takao@jp.fujitsu.com, izumi.taku@jp.fujitsu.com
X-Original-Date	Thu, 7 Sep 2017 10:34:20 +0800
X-Original-Message-ID	<20170907023420.GN30906@x1>
X-Original-References	<1503890438-27840-1-git-send-email-douly.fnst@cn.fujitsu.com> <1503890438-27840-7-git-send-email-douly.fnst@cn.fujitsu.com> <20170906042514.GF30906@x1> <20170906052614.GG30906@x1> <96aae229-04d4-fc31-9646-3ca7c029365a@cn.fujitsu.com> <20170906080304.GJ30906@x1> <1d29b070-2922-2ac7-febf-491bd49f542f@cn.fujitsu.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1727878

Show key headers only | View raw

On 09/07/17 at 10:27am, Dou Liyang wrote:
> 
> 
> At 09/06/2017 04:03 PM, Baoquan He wrote:
> > On 09/06/17 at 01:41pm, Dou Liyang wrote:
> > > Hi Baoquan,
> > > 
> > > At 09/06/2017 01:26 PM, Baoquan He wrote:
> > > [...]
> > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > > index 4f63afc..9f8479c 100644
> > > --- a/arch/x86/kernel/smpboot.c
> > > +++ b/arch/x86/kernel/smpboot.c
> > > @@ -1260,8 +1260,10 @@ static void __init smp_get_logical_apicid(void)
> > >  }
> > > 
> > >  /*
> > > - * Prepare for SMP bootup.  The MP table or ACPI has been read
> > > - * earlier.  Just do some sanity checking here and enable APIC mode.
> > > + * Prepare for SMP bootup.
> > > + *
> > > + * @max_cpus: configured maximum number of CPUs
> > > + * It don't be used, but other arch also have this hook, so keep it.
> 
> How about:
> 
> @max_cpus: configured maximum number of CPUs
> It is a legacy parameter for common interface support

Looks good to me.

> 
> > 
> > Yeah, makes sense. Above words can be reconsidered.
> > 
> 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-08-28 05:30 +0200
  Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 06:30 +0200
    Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 07:30 +0200
      Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-09-06 07:50 +0200
        Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 10:10 +0200
          Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-09-07 04:30 +0200
            Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-07 04:40 +0200

csiph-web