Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup

From	Baoquan He <bhe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup
Date	2017-09-07 04:40 +0200
Message-ID	<umUTw-233-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <umA8p-4yB-1@gated-at.bofh.it> <umB4t-5b7-7@gated-at.bofh.it> <umBnP-5iy-9@gated-at.bofh.it> <umDzj-7di-7@gated-at.bofh.it> <umUJP-1ZS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/07/17 at 10:27am, Dou Liyang wrote:
> 
> 
> At 09/06/2017 04:03 PM, Baoquan He wrote:
> > On 09/06/17 at 01:41pm, Dou Liyang wrote:
> > > Hi Baoquan,
> > > 
> > > At 09/06/2017 01:26 PM, Baoquan He wrote:
> > > [...]
> > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > > index 4f63afc..9f8479c 100644
> > > --- a/arch/x86/kernel/smpboot.c
> > > +++ b/arch/x86/kernel/smpboot.c
> > > @@ -1260,8 +1260,10 @@ static void __init smp_get_logical_apicid(void)
> > >  }
> > > 
> > >  /*
> > > - * Prepare for SMP bootup.  The MP table or ACPI has been read
> > > - * earlier.  Just do some sanity checking here and enable APIC mode.
> > > + * Prepare for SMP bootup.
> > > + *
> > > + * @max_cpus: configured maximum number of CPUs
> > > + * It don't be used, but other arch also have this hook, so keep it.
> 
> How about:
> 
> @max_cpus: configured maximum number of CPUs
> It is a legacy parameter for common interface support

Looks good to me.

> 
> > 
> > Yeah, makes sense. Above words can be reconsidered.
> > 
> 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-08-28 05:30 +0200
  Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 06:30 +0200
    Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 07:30 +0200
      Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-09-06 07:50 +0200
        Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-06 10:10 +0200
          Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-09-07 04:30 +0200
            Re: [PATCH v8 06/13] x86/apic: Mark the apic_intr_mode extern for  sanity check cleanup Baoquan He <bhe@redhat.com> - 2017-09-07 04:40 +0200

csiph-web